[Bdt] Switch to dcargs #69
Conversation
Signed-off-by: Greg Balke <[email protected]> Topic: bdt_uses_dcargs Reviewers: brent
|
Reviews in this chain: |
bd_tools/src/bd_tools/boards.py
Outdated
| """ | ||
|
|
||
|
|
||
| actuation: dcargs.conf.Positional[str] |
There was a problem hiding this comment.
probably a literal could be used here?
from typing import Literal
actuation: Literal["current", "phase"], etc
|
|
||
|
|
||
| actuation: dcargs.conf.Positional[str] | ||
| values: dcargs.conf.Positional[List[Tuple[float, float, float]]] |
There was a problem hiding this comment.
in general, variable-length positional arguments are scary because it means you can't have add more positional args afterward
| @@ -35,7 +52,9 @@ def make_list(x): | |||
| def make_type(x, to_type): | |||
| return [to_type(y) for y in x] | |||
|
|
|||
| board_ids = make_type(make_list(ast.literal_eval(args.board_ids)), int) | |||
| board_ids = make_type( | |||
| make_list(ast.literal_eval(args.motor.board_ids)), int | |||
There was a problem hiding this comment.
is this still needed? since board_ids is annotated as List[int] now
|
Discussed offline... I think the current behavior where betz drive tools creates a connection per tool execution is a pretty poor design for doing continuous testing. I believe |
gbalke
force-pushed
the
gbalke/revup/master/bdt_uses_dcargs
branch
from
83f4182
to
0b7072f
Compare
Signed-off-by: Greg Balke [email protected]
Topic: bdt_uses_dcargs
Reviewers: brent